* <!--
* Copyright 2003,2004 Develer S.r.l. (http://www.develer.com/)
* Copyright 2000 Bernardo Innocenti <bernie@codewiz.org>
- * All Rights Reserved.
+ * This file is part of DevLib - See devlib/README for information.
* -->
*
* \brief Buffered serial I/O driver
/*
* $Log$
+ * Revision 1.6 2004/06/07 15:56:28 aleph
+ * Remove cast-as-lvalue extension abuse
+ *
+ * Revision 1.5 2004/06/06 16:41:44 bernie
+ * ser_putchar(): Use fifo_push_locked() to fix potential race on 8bit processors.
+ *
+ * Revision 1.4 2004/06/03 11:27:09 bernie
+ * Add dual-license information.
+ *
* Revision 1.3 2004/06/02 21:35:24 aleph
* Serial enhancements: interruptible receive handler and 8 bit serial status for AVR; remove volatile attribute to FIFOBuffer, useless for new fifobuf routens
*
while (fifo_isfull_locked(&port->txfifo));
}
- fifo_push(&port->txfifo, (unsigned char)c);
+ fifo_push_locked(&port->txfifo, (unsigned char)c);
/* (re)trigger tx interrupt */
port->hw->table->enabletxirq(port->hw);
* \brief Write a buffer to serial.
*
* \return 0 if OK, EOF in case of error.
+ *
+ * \todo Optimize with fifo_pushblock()
*/
-int ser_write(struct Serial *port, const void *buf, size_t len)
+int ser_write(struct Serial *port, const void *_buf, size_t len)
{
+ const char *buf = _buf;
+
while (len--)
{
- if (ser_putchar(*((const char *)buf)++, port) == EOF)
+ if (ser_putchar(*buf++, port) == EOF)
return EOF;
}
return 0;