X-Git-Url: https://codewiz.org/gitweb?a=blobdiff_plain;f=bertos%2Fkern%2Fpreempt.c;h=4b1ad9ee2d5dea8e213570eeb1c59fc400290fa6;hb=e62ca0b357f09804d7d894949df44224c9d74bb7;hp=e24da145ba1c38ee09fc9363060c9bb0e46aec39;hpb=b0033f388edf3db04aec0901420a06bbc0f7ada7;p=bertos.git

diff --git a/bertos/kern/preempt.c b/bertos/kern/preempt.c
index e24da145..4b1ad9ee 100644
--- a/bertos/kern/preempt.c
+++ b/bertos/kern/preempt.c
@@ -50,6 +50,7 @@
 
 #include "proc_p.h"
 #include "proc.h"
+#include "idle.h"
 
 #include <kern/irq.h>
 #include <kern/monitor.h>
@@ -64,20 +65,17 @@ CONFIG_DEPEND(CONFIG_KERN_PREEMPT,    CONFIG_KERN_SCHED && CONFIG_TIMER_EVENTS &
 
 MOD_DEFINE(preempt)
 
-int preempt_forbid_cnt;
+/// Global preemption disabling nesting counter
+cpu_atomic_t _preempt_forbid_cnt;
 
 static Timer preempt_timer;
 
 
-// fwd decl from idle.c
-void idle_init(void);
-
-
 void proc_schedule(void)
 {
 	IRQ_DISABLE;
 
-	ASSERT(preempt_forbid_cnt == 0);
+	ASSERT(proc_allowed());
 	LIST_ASSERT_VALID(&ProcReadyList);
 	CurrentProcess = (struct Process *)list_remHead(&ProcReadyList);
 	ASSERT2(CurrentProcess, "no idle proc?");
@@ -87,9 +85,9 @@ void proc_schedule(void)
 	TRACEMSG("launching %p:%s", CurrentProcess, proc_currentName());
 }
 
-void proc_preempt(UNUSED_ARG(void *, param)
+void proc_preempt(UNUSED_ARG(void *, param))
 {
-	if (!preempt_forbid_cnt)
+	if (proc_allowed())
 	{
 		IRQ_DISABLE;
 
@@ -101,7 +99,7 @@ void proc_preempt(UNUSED_ARG(void *, param)
 
 		TRACEMSG("preempting %p:%s", CurrentProcess, proc_currentName());
 
-// FIXME: this still break havocs, probably because of some reentrancy issue
+// FIXME: this still breaks havoc, probably because of some reentrancy issue
 #if 0
 		SCHED_ENQUEUE(CurrentProcess);
 		proc_schedule();
@@ -125,9 +123,9 @@ void proc_switch(void)
 
 	/* Sleeping with IRQs disabled or preemption forbidden is illegal */
 	IRQ_ASSERT_ENABLED();
-	ASSERT(preempt_forbid_cnt == 0);
+	ASSERT(proc_allowed());
 
-	// Will invoke proc_preempt() in interrupt context
+	// Will invoke proc_switch() in interrupt context
 	kill(0, SIGUSR1);
 }
 
@@ -153,9 +151,9 @@ void preempt_init(void)
 	MOD_CHECK(irq);
 	MOD_CHECK(timer);
 
-	irq_register(SIGUSR1, proc_preempt);
+	irq_register(SIGUSR1, proc_schedule);
 
-	timer_setSoftint(&preempt_timer, proc_preempt_timer, NULL);
+	timer_setSoftint(&preempt_timer, proc_preempt, NULL);
 	timer_setDelay(&preempt_timer, CONFIG_KERN_QUANTUM);
 	timer_add(&preempt_timer);