X-Git-Url: https://codewiz.org/gitweb?a=blobdiff_plain;f=bertos%2Fnet%2Fafsk.c;h=d58758cd8397031613a1e8b9395f7421b5edc241;hb=bfe473a7e8951b16edbd6559b828a37e6ce378aa;hp=01b4347423030e146af30799870886d7eed1fda3;hpb=2a398044dd1d7b2af34a96c19ad378c25b546579;p=bertos.git

diff --git a/bertos/net/afsk.c b/bertos/net/afsk.c
index 01b43474..d58758cd 100644
--- a/bertos/net/afsk.c
+++ b/bertos/net/afsk.c
@@ -32,8 +32,7 @@
  *
  * \brief AFSK1200 modem.
  *
- * \version $Id$
- * \author Francesco Sacchi <asterix@develer.com>
+ * \author Francesco Sacchi <batt@develer.com>
  */
 
 #include "afsk.h"
@@ -106,11 +105,7 @@ INLINE uint8_t sin_sample(uint16_t idx)
 	uint16_t new_idx = idx % (SIN_LEN / 2);
 	new_idx = (new_idx >= (SIN_LEN / 4)) ? (SIN_LEN / 2 - new_idx - 1) : new_idx;
 
-	#if CPU_HARVARD
-		uint8_t data = pgm_read_char(&sin_table[new_idx]);
-	#else
-		uint8_t data = sin_table[new_idx];
-	#endif
+	uint8_t data = pgm_read8(&sin_table[new_idx]);
 
 	return (idx >= (SIN_LEN / 2)) ? (255 - data) : data;
 }
@@ -119,7 +114,16 @@ INLINE uint8_t sin_sample(uint16_t idx)
 #define BIT_DIFFER(bitline1, bitline2) (((bitline1) ^ (bitline2)) & 0x01)
 #define EDGE_FOUND(bitline)            BIT_DIFFER((bitline), (bitline) >> 1)
 
-
+/**
+ * High-Level Data Link Control parsing function.
+ * Parse bitstream in order to find characters.
+ *
+ * \param hdlc HDLC context.
+ * \param bit  current bit to be parsed.
+ * \param fifo FIFO buffer used to push characters.
+ *
+ * \return true if all is ok, false if the fifo is full.
+ */
 static bool hdlc_parse(Hdlc *hdlc, bool bit, FIFOBuffer *fifo)
 {
 	bool ret = true;
@@ -200,7 +204,7 @@ static bool hdlc_parse(Hdlc *hdlc, bool bit, FIFOBuffer *fifo)
  * ADC ISR callback.
  * This function has to be called by the ADC ISR when a sample of the configured
  * channel is available.
- * \param af Afsk context to operate one (\see Afsk).
+ * \param af Afsk context to operate on.
  * \param curr_sample current sample from the ADC.
  */
 void afsk_adc_isr(Afsk *af, int8_t curr_sample)
@@ -331,13 +335,14 @@ static void afsk_txStart(Afsk *af)
  * This function has to be called by the DAC ISR when a sample of the configured
  * channel has been converted out.
  *
- * \param af Afsk context to operate one (\see Afsk).
+ * \param af Afsk context to operate on.
  *
- * \note The next DAC output sample is supplied by the Afsk driver through calling
- *        the AFSK_DAC_SET() callback.
+ * \return The next DAC output sample.
  */
-void afsk_dac_isr(Afsk *af)
+uint8_t afsk_dac_isr(Afsk *af)
 {
+	AFSK_STROBE_ON();
+
 	/* Check if we are at a start of a sample cycle */
 	if (af->sample_count == 0)
 	{
@@ -348,7 +353,8 @@ void afsk_dac_isr(Afsk *af)
 			{
 				AFSK_DAC_IRQ_STOP(af->dac_ch);
 				af->sending = false;
-				return;
+				AFSK_STROBE_OFF();
+				return 0;
 			}
 			else
 			{
@@ -387,7 +393,8 @@ void afsk_dac_isr(Afsk *af)
 					{
 						AFSK_DAC_IRQ_STOP(af->dac_ch);
 						af->sending = false;
-						return;
+						AFSK_STROBE_OFF();
+						return 0;
 					}
 					else
 						af->curr_out = fifo_pop(&af->tx_fifo);
@@ -444,8 +451,9 @@ void afsk_dac_isr(Afsk *af)
 	af->phase_acc += af->phase_inc;
 	af->phase_acc %= SIN_LEN;
 
-	AFSK_DAC_SET(af->dac_ch, sin_sample(af->phase_acc));
 	af->sample_count--;
+	AFSK_STROBE_OFF();
+	return sin_sample(af->phase_acc);
 }
 
 
@@ -464,7 +472,7 @@ static size_t afsk_read(KFile *fd, void *_buf, size_t size)
 		ticks_t start = timer_clock();
 		#endif
 
-		while (fifo_isempty_locked(&af->rx_fifo));
+		while (fifo_isempty_locked(&af->rx_fifo))
 		{
 			cpu_relax();
 			#if CONFIG_AFSK_RXTIMEOUT != -1
@@ -522,7 +530,7 @@ static void afsk_clearerr(KFile *fd)
 
 /**
  * Initialize an AFSK1200 modem.
- * \param af Afsk context to operate one (\see Afsk).
+ * \param af Afsk context to operate on.
  * \param adc_ch  ADC channel used by the demodulator.
  * \param dac_ch  DAC channel used by the modulator.
  */