X-Git-Url: https://codewiz.org/gitweb?a=blobdiff_plain;f=drv%2Fkdebug.c;h=bd21cbbbf7700bf57b5226863cd33815f493c7c7;hb=7920ccf2c9be523f680d88ef7d681d09af7da209;hp=d80be75681f901a215bce5d7273deb9dec7f95f8;hpb=af9c555446161016fdd76c1cdff96ce76bb6cba2;p=bertos.git

diff --git a/drv/kdebug.c b/drv/kdebug.c
index d80be756..bd21cbbb 100755
--- a/drv/kdebug.c
+++ b/drv/kdebug.c
@@ -1,4 +1,4 @@
-/*!
+/**
  * \file
  * <!--
  * Copyright 2003, 2004, 2005 Develer S.r.l. (http://www.develer.com/)
@@ -15,6 +15,21 @@
 
 /*#*
  *#* $Log$
+ *#* Revision 1.28  2006/07/19 12:56:25  bernie
+ *#* Convert to new Doxygen style.
+ *#*
+ *#* Revision 1.27  2006/06/01 12:32:06  marco
+ *#* Updated include reference.
+ *#*
+ *#* Revision 1.26  2006/04/27 05:40:27  bernie
+ *#* Break on assertion failures.
+ *#*
+ *#* Revision 1.25  2005/06/27 21:26:24  bernie
+ *#* Misc PGM fixes.
+ *#*
+ *#* Revision 1.24  2005/04/12 01:36:37  bernie
+ *#* Add hack to enable TX line at module initialization.
+ *#*
  *#* Revision 1.23  2005/04/11 19:10:27  bernie
  *#* Include top-level headers from cfg/ subdir.
  *#*
@@ -34,8 +49,8 @@
 #include <cfg/debug.h>
 #include <cfg/cpu.h>
 #include <cfg/macros.h> /* for BV() */
-#include <cfg/config.h>
-#include <hw.h>
+#include <appconfig.h>
+#include <hw_cpu.h>     /* for CLOCK_FREQ */
 
 #include <mware/formatwr.h> /* for _formatted_write() */
 
@@ -67,9 +82,16 @@
 		/*
 		 * Support for special bus policies or external transceivers
 		 * on UART0 (to be overridden in "hw.h").
+		 *
+		 * HACK: if we don't set TXEN, kdbg disables the transmitter
+		 * after each output statement until the serial driver
+		 * is initialized.  These glitches confuse the debug
+		 * terminal that ends up printing some trash.
 		 */
 		#ifndef KDBG_UART0_BUS_INIT
-		#define KDBG_UART0_BUS_INIT  do {} while (0)
+		#define KDBG_UART0_BUS_INIT  do { \
+				UCSR0B = BV(TXEN); \
+			} while (0)
 		#endif
 		#ifndef KDBG_UART0_BUS_RX
 		#define KDBG_UART0_BUS_RX    do {} while (0)
@@ -78,7 +100,7 @@
 		#define KDBG_UART0_BUS_TX    do {} while (0)
 		#endif
 
-		#if CPU_AVR_ATMEGA64
+		#if CPU_AVR_ATMEGA64 || CPU_AVR_ATMEGA128
 			#define UCR UCSR0B
 			#define UDR UDR0
 			#define USR UCSR0A
@@ -123,9 +145,16 @@
 		/*
 		 * Support for special bus policies or external transceivers
 		 * on UART1 (to be overridden in "hw.h").
+		 *
+		 * HACK: if we don't set TXEN, kdbg disables the transmitter
+		 * after each output statement until the serial driver
+		 * is initialized.  These glitches confuse the debug
+		 * terminal that ends up printing some trash.
 		 */
 		#ifndef KDBG_UART1_BUS_INIT
-		#define KDBG_UART1_BUS_INIT  do {} while (0)
+		#define KDBG_UART1_BUS_INIT  do { \
+				UCSR1B = BV(TXEN); \
+			} while (0)
 		#endif
 		#ifndef KDBG_UART1_BUS_RX
 		#define KDBG_UART1_BUS_RX    do {} while (0)
@@ -186,7 +215,7 @@ void kdbg_init(void)
 	/* Compute the baud rate */
 	uint16_t period = (((CLOCK_FREQ / 16UL) + (CONFIG_KDEBUG_BAUDRATE / 2)) / CONFIG_KDEBUG_BAUDRATE) - 1;
 
-	#if CPU_AVR_ATMEGA64
+	#if CPU_AVR_ATMEGA64 || CPU_AVR_ATMEGA128
 		#if CONFIG_KDEBUG_PORT == 0
 			UBRR0H = (uint8_t)(period>>8);
 			UBRR0L = (uint8_t)period;
@@ -214,7 +243,7 @@ void kdbg_init(void)
 }
 
 
-/*!
+/**
  * Output one character to the debug console
  */
 static void __kputchar(char c, UNUSED_ARG(void *, unused))
@@ -287,7 +316,7 @@ void PGM_FUNC(kputs)(const char * PGM_ATTR str)
 }
 
 
-/*!
+/**
  * Cheap function to print small integers without using printf().
  */
 int kputnum(int num)
@@ -318,15 +347,16 @@ static void klocation(const char * PGM_ATTR file, int line)
 	PGM_FUNC(kputs)(file);
 	kputchar(':');
 	kputnum(line);
-	PGM_FUNC(kputs)(PSTR(": "));
+	PGM_FUNC(kputs)(PGM_STR(": "));
 }
 
 int PGM_FUNC(__assert)(const char * PGM_ATTR cond, const char * PGM_ATTR file, int line)
 {
 	klocation(file, line);
-	PGM_FUNC(kputs)(PSTR("Assertion failed: "));
+	PGM_FUNC(kputs)(PGM_STR("Assertion failed: "));
 	PGM_FUNC(kputs)(cond);
 	kputchar('\n');
+	BREAKPOINT;
 	return 1;
 }
 
@@ -337,26 +367,27 @@ int PGM_FUNC(__assert)(const char * PGM_ATTR cond, const char * PGM_ATTR file, i
  */
 void PGM_FUNC(__trace)(const char *name)
 {
-	PGM_FUNC(kprintf)(PSTR("%s()\n"), name);
+	PGM_FUNC(kprintf)(PGM_STR("%s()\n"), name);
 }
 
 void PGM_FUNC(__tracemsg)(const char *name, const char * PGM_ATTR fmt, ...)
 {
 	va_list ap;
 
-	PGM_FUNC(kprintf)(PSTR("%s(): "), name);
+	PGM_FUNC(kprintf)(PGM_STR("%s(): "), name);
 	va_start(ap, fmt);
 	PGM_FUNC(kvprintf)(fmt, ap);
 	va_end(ap);
+	kputchar('\n');
 }
 
 int PGM_FUNC(__invalid_ptr)(void *value, const char * PGM_ATTR name, const char * PGM_ATTR file, int line)
 {
 	klocation(file, line);
-	PGM_FUNC(kputs)(PSTR("Invalid ptr: "));
+	PGM_FUNC(kputs)(PGM_STR("Invalid ptr: "));
 	PGM_FUNC(kputs)(name);
 	#if CONFIG_PRINTF
-		PGM_FUNC(kprintf)(PSTR(" = 0x%x\n"), value);
+		PGM_FUNC(kprintf)(PGM_STR(" = 0x%x\n"), (unsigned int)value);
 	#else
 		(void)value;
 		kputchar('\n');
@@ -381,10 +412,10 @@ int PGM_FUNC(__check_wall)(long *wall, int size, const char * PGM_ATTR name, con
 		if (wall[i] != WALL_VALUE)
 		{
 			klocation(file, line);
-			PGM_FUNC(kputs)(PSTR("Wall broken: "));
+			PGM_FUNC(kputs)(PGM_STR("Wall broken: "));
 			PGM_FUNC(kputs)(name);
 			#if CONFIG_PRINTF
-				PGM_FUNC(kprintf)(PSTR("[%d] (0x%p) = 0x%lx\n"), i, wall + i, wall[i]);
+				PGM_FUNC(kprintf)(PGM_STR("[%d] (0x%p) = 0x%lx\n"), i, wall + i, wall[i]);
 			#else
 				kputchar('\n');
 			#endif
@@ -398,7 +429,7 @@ int PGM_FUNC(__check_wall)(long *wall, int size, const char * PGM_ATTR name, con
 
 #if CONFIG_PRINTF
 
-/*!
+/**
  * Dump binary data in hex
  */
 void kdump(const void *_buf, size_t len)