X-Git-Url: https://codewiz.org/gitweb?a=blobdiff_plain;f=src%2Fshare%2Fmh%2Frevoke_hostname;h=b3b8d7a330481e70acfa17d7bc88f0670221d51d;hb=80f608dfb8cd0a59609f3c98834e44f0c78fffb0;hp=92383a08f5757292d7ebfdbc97efaae21a342629;hpb=d0459e29cb1a6f6196e3e12ccc4da47601514d67;p=monkeysphere.git diff --git a/src/share/mh/revoke_hostname b/src/share/mh/revoke_hostname index 92383a0..b3b8d7a 100644 --- a/src/share/mh/revoke_hostname +++ b/src/share/mh/revoke_hostname @@ -19,7 +19,6 @@ local userID local fingerprint local tmpuidMatch local line -local uidIndex local message local revuidCommand @@ -27,25 +26,15 @@ if [ -z "$1" ] ; then failure "You must specify a hostname to revoke." fi -echo "WARNING: There is a known bug in this function." -echo "This function has been known to occasionally revoke the wrong user ID." -echo "Please see the following bug report for more information:" -echo "https://labs.riseup.net/code/issues/show/422" -read -p "Are you sure you would like to proceed? (y/N) " OK; OK=${OK:=N} -if [ ${OK/y/Y} != 'Y' ] ; then - failure "aborting." -fi - userID="ssh://${1}" # make sure the user ID to revoke -uidIndex=$(find_host_userid) || \ +find_host_userid "$userID" || \ failure "No non-revoked user ID found matching '$userID'." if [ "$PROMPT" = "true" ] ; then - echo "The following host key user ID will be revoked:" - echo " $userID" - read -p "Are you sure you would like to revoke this user ID? (N/y) " OK; OK=${OK:=Y} + printf "The following host key user ID will be revoked:\n %s\nAre you sure you would like to revoke this user ID? (Y/n) " "$userID" >&2 + read OK; OK=${OK:=Y} if [ "${OK/y/Y}" != 'Y' ] ; then failure "User ID not revoked." fi @@ -53,21 +42,10 @@ else log debug "revoking user ID without prompting." fi -# edit-key script command to revoke user ID -revuidCommand=$(cat <