Try to fix monkeysphere-host and tests/basic for revoke-key test

Unfortunately there's still a problem that I can't quite figure out.
gpg is for some reason failing to import that revocation certificate.
Could it be because gpg can't accept ascii armored certificates as
input?  I'm at a loss.

diff --git a/src/monkeysphere-host b/src/monkeysphere-host
index b45b50ec60e38c9969426119c469e968751d5dbc..903e3335c8f34a6735defbda1b5cf05f9b28c132 100755 (executable)
--- a/src/monkeysphere-host
+++ b/src/monkeysphere-host
@@ -174,11 +174,6 @@ multi_key() {
 
     if [[ -z "$1" || "$1" == '--all' ]] ; then
        keys="${fprs[@]}"
-    else
-       for key in $keys ; do
-           printf '%s\n' "${fprs[@]}" | grep "${key}$" \
-               || failure "Key '$key' not found."
-       done
     fi
 
     for key in $keys ; do
@@ -208,7 +203,10 @@ show_key() {
 
     # create the ssh key
     TMPSSH="$GNUPGHOME"/ssh_host_key_rsa_pub
-    gpg --export "$id" | openpgp2ssh 2>/dev/null >"$TMPSSH"
+    if ! gpg --export "$id" 2>/dev/null \
+       | openpgp2ssh 2>/dev/null >"$TMPSSH" ; then
+       failure "Key '$id' not found."
+    fi
 
     # get the gpg fingerprint
     fingerprint=$(gpg --quiet --list-keys \

diff --git a/tests/basic b/tests/basic
index 15afa77fe1dd4bf7817395f61930677e0b7e6e1a..d9b7f445e51b227a3dddafbfa08811eda15526be 100755 (executable)
--- a/tests/basic
+++ b/tests/basic
@@ -567,7 +567,10 @@ echo "##################################################"
 echo "### revoking ssh host key..."
 # generate the revocation certificate and feed it directly to the test
 # user's keyring (we're not publishing to the keyservers)
-monkeysphere-host revoke-key | gpg --import
+keyID=$(monkeysphere-host s 'https://testhost' | grep 'OpenPGP fingerprint:' | awk '{ print $3 }')
+monkeysphere-host revoke-key "$keyID" >"$TEMPDIR"/revcert
+cat "$TEMPDIR"/revcert
+<"$TEMPDIR"/revcert gpg --import
 echo
 echo "##################################################"
 echo "### ssh connection test for failure..."