From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Date: Mon, 23 Mar 2009 20:54:20 +0000 (-0400)
Subject: add FIXME note about IPv6 addresses, and break out hostnames from the last colon... 
X-Git-Tag: monkeysphere_0.25~32^2~3
X-Git-Url: https://codewiz.org/gitweb?a=commitdiff_plain;h=b701db93e07fa839cf599577b45ccf3ff7b71351;hp=ebce95fb2c3f4975adf346899ce3b0ebbe9d2710;p=monkeysphere.git

add FIXME note about IPv6 addresses, and break out hostnames from the last colon, not the first.
---

diff --git a/src/share/common b/src/share/common
index 5a11817..d6e4949 100644
--- a/src/share/common
+++ b/src/share/common
@@ -467,7 +467,11 @@ ssh2known_hosts() {
     local port
     local key
 
-    host=${1%%:*}
+    # FIXME this does not properly deal with IPv6 hosts using the
+    # standard port (because it's unclear whether their final
+    # colon-delimited address section is a port number or an address
+    # string)
+    host=${1%:*}
     port=${1##*:}
     key="$2"