From 014d5c705784bfe7b47731ad5cc50568fc5e63cf Mon Sep 17 00:00:00 2001 From: Bernardo Innocenti Date: Thu, 17 Jan 2008 14:36:04 -0500 Subject: [PATCH] First pass of pylint warning removal --- geekigeeki.py | 86 +++++++++++++++++++++++---------------------------- 1 file changed, 39 insertions(+), 47 deletions(-) diff --git a/geekigeeki.py b/geekigeeki.py index db11433..b34f152 100755 --- a/geekigeeki.py +++ b/geekigeeki.py @@ -23,7 +23,7 @@ __version__ = '$Id$'[4:12] from time import clock start_time = clock() -import cgi, sys, string, os, re, errno, stat +import cgi, sys, os, re, errno, stat from os import path, environ # Regular expression defining a WikiWord @@ -57,30 +57,29 @@ def get_hostname(addr): try: from socket import gethostbyaddr return gethostbyaddr(addr)[0] + ' (' + addr + ')' - except: + except Exception, er: return addr -def relative_url(path, privileged=False): - if not (url_re.match(path) or path.startswith('/')): +def relative_url(pathname, privileged=False): + if not (url_re.match(pathname) or pathname.startswith('/')): if privileged: url = privileged_path() else: url = script_name() - path = url + '/' + path - return path + pathname = url + '/' + pathname + return pathname # Formatting stuff -------------------------------------------------- -def emit_header(type="text/html"): - print "Content-type: " + type + "; charset=utf-8" - print +def emit_header(mime_type="text/html"): + print "Content-type: " + mime_type + "; charset=utf-8\n" -def send_guru(msg, msg_type): - if msg is None or msg == '': return +def send_guru(msg_text, msg_type): + if not msg_text: return print '
'
     if msg_type == 'error':
         print '    Software Failure.  Press left mouse button to continue.\n'
-    print msg
+    print msg_text
     if msg_type == 'error':
         print '      Guru Meditation #DEADBEEF.ABADC0DE'
     print '
' @@ -107,7 +106,7 @@ def send_guru(msg, msg_type): } """ -def send_title(name, text="Limbo", msg=None, msg_type='error'): +def send_title(name, text="Limbo", msg_text=None, msg_type='error'): global title_done if title_done: return @@ -133,7 +132,7 @@ def send_title(name, text="Limbo", msg=None, msg_type='error'): print '' title_done = True - send_guru(msg, msg_type) + send_guru(msg_text, msg_type) # Navbar print '
' @@ -226,7 +225,6 @@ def do_raw(pagename): Page(pagename).send_raw() def do_edit(pagename): - global form pg = Page(pagename) if 'preview' in form: pg.send_editor(form['savetext'].value) @@ -234,19 +232,15 @@ def do_edit(pagename): pg.save_text(form['savetext'].value) pg.send_page() elif 'cancel' in form: - pg.msg = 'Editing canceled' + pg.msg_text = 'Editing canceled' pg.msg_type = 'notice' pg.send_page() else: pg.send_editor() def make_index_key(): - s = '

' - links = map(lambda ch: '%s' % (ch, ch), - string.lowercase) - s = s + string.join(links, ' | ') - s = s + '

' - return s + links = map(lambda ch: '%s' % (ch, ch), 'abcdefghijklmnopqrstuvwxyz') + return '

'+ ' | '.join(links) + '

' def page_list(): return filter(word_re.match, os.listdir(data_dir)) @@ -256,7 +250,6 @@ def send_footer(name, mod_string=None): cgi.print_arguments() cgi.print_form(cgi.FieldStorage()) cgi.print_environ() - global __version__ print '