Merge commit 'jrollins/master'

[monkeysphere.git] / src / keytrans / gnutls-helpers.c

diff --git a/src/keytrans/gnutls-helpers.c b/src/keytrans/gnutls-helpers.c
index c6e4979b66665b9cb0df3e241cb7a351efd908e0..5b4c46af187a2c662fb8ea97f66a54355cd1a5c2 100644 (file)
--- a/src/keytrans/gnutls-helpers.c
+++ b/src/keytrans/gnutls-helpers.c
@@ -15,11 +15,15 @@
 /* for exit() */
 #include <unistd.h>
 
+#include <assert.h>
+
+/* higher levels allow more frivolous error messages through. 
+   this is set with the MONKEYSPHERE_DEBUG variable */
 static int loglevel = 0;
 
 void err(int level, const char* fmt, ...) {
   va_list ap;
-  if (level < loglevel)
+  if (level > loglevel)
     return;
   va_start(ap, fmt);
   vfprintf(stderr, fmt, ap);
@@ -38,14 +42,21 @@ void init_keyid(gnutls_openpgp_keyid_t keyid) {
 
 
 void make_keyid_printable(printable_keyid out, gnutls_openpgp_keyid_t keyid)
+{
+  assert(sizeof(out) >= 2*sizeof(keyid));
+  hex_print_data((char*)out, (const char*)keyid, sizeof(keyid));
+}
+
+/* you must have twice as many bytes in the out buffer as in the in buffer */
+void hex_print_data(char* out, const char* in, size_t incount)
 {
   static const char hex[16] = "0123456789ABCDEF";
-  unsigned int kix = 0, outix = 0;
+  unsigned int inix = 0, outix = 0;
   
-  while (kix < sizeof(gnutls_openpgp_keyid_t)) {
-    out[outix] = hex[(keyid[kix] >> 4) & 0x0f];
-    out[outix + 1] = hex[keyid[kix] & 0x0f];
-    kix++;
+  while (inix < incount) {
+    out[outix] = hex[(in[inix] >> 4) & 0x0f];
+    out[outix + 1] = hex[in[inix] & 0x0f];
+    inix++;
     outix += 2;
   }
 }