add FIXME note about IPv6 addresses, and break out hostnames from the last colon...
authorDaniel Kahn Gillmor <dkg@fifthhorseman.net>
Mon, 23 Mar 2009 20:54:20 +0000 (16:54 -0400)
committerDaniel Kahn Gillmor <dkg@fifthhorseman.net>
Mon, 23 Mar 2009 20:54:20 +0000 (16:54 -0400)
src/share/common

index 5a118172d72774b7ae341269b9ef6bd17f864774..d6e494953d078e1178c1dda7addc3cf985196f1e 100644 (file)
@@ -467,7 +467,11 @@ ssh2known_hosts() {
     local port
     local key
 
-    host=${1%%:*}
+    # FIXME this does not properly deal with IPv6 hosts using the
+    # standard port (because it's unclear whether their final
+    # colon-delimited address section is a port number or an address
+    # string)
+    host=${1%:*}
     port=${1##*:}
     key="$2"